Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI for forks #738

Merged
merged 20 commits into from
Sep 3, 2024
Merged

Fix CI for forks #738

merged 20 commits into from
Sep 3, 2024

Conversation

makslevental
Copy link
Collaborator

@makslevental makslevental commented Sep 3, 2024 •
edited
Loading

♥️ @newling

@makslevental makslevental changed the title Fix CI for forks [wip] Fix CI for forks Sep 3, 2024
@makslevental makslevental changed the title [wip] Fix CI for forks Fix CI for forks Sep 3, 2024
jtuyls
jtuyls approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@jtuyls jtuyls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix!

@makslevental
Copy link
Collaborator Author

Note the README doesn't need to be updated because a clone from this repo (as tested by the previous CI yml) works fine

@makslevental makslevental merged commit a0c372a into nod-ai:main Sep 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtuyls jtuyls jtuyls approved these changes

@newling newling Awaiting requested review from newling

@Abhishek-Varma Abhishek-Varma Awaiting requested review from Abhishek-Varma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makslevental @jtuyls